Skip to content

feat(app): compile server with babel-runtime #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kingcody
Copy link
Member

@kingcody kingcody commented Sep 6, 2015

No description provided.

@kingcody kingcody added this to the 3.0.0 milestone Sep 6, 2015
@Awk34
Copy link
Member

Awk34 commented Sep 6, 2015

Awesome! You got this up quick

@kingcody kingcody force-pushed the feature/compile-server-on-build branch from 02e26b5 to 8b708e2 Compare September 6, 2015 14:32
// Set default node environment to development
var env = process.env.NODE_ENV = process.env.NODE_ENV || 'development';

if (env === 'production' || env === 'test') {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was missing env === 'test'.

Awk34 added a commit that referenced this pull request Sep 6, 2015
feat(app): compile server with babel-runtime
@Awk34 Awk34 merged commit af4b908 into angular-fullstack:canary Sep 6, 2015
@kingcody kingcody deleted the feature/compile-server-on-build branch September 9, 2015 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants